Skip to content

add the word background to bgcolor description so it will get indexed by algolia #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jdamiba
Copy link

@jdamiba jdamiba commented Feb 3, 2020

The purpose of this PR is to make sure that plot_bgcolor and paper_bgcolor show up in algolia search results for background.

Related to plotly/plotly.js#4536

@jdamiba jdamiba requested a review from emmanuelle February 3, 2020 18:07
@nicolaskruchten
Copy link
Contributor

Thanks for this PR! It's not actually necessary, though, as this code is automatically-generated by the release process, and only deployed to the docs when master is merged to doc-prod thereafter.

@emmanuelle
Copy link
Contributor

@nicolaskruchten you mean, because the JS doc has already been updated?

@nicolaskruchten
Copy link
Contributor

Oh, no, I meant this change will come in automatically when we codegen for 1.52.2, and then we'll deploy to prod. We don't need to make these changes piecemeal here in Python when we do them in JS.

@jdamiba jdamiba closed this Feb 4, 2020
@nicolaskruchten nicolaskruchten deleted the update-plot-paper-description branch June 19, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants