Refactoring of axes tutorial #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| layout=go.Layout( | ||
| xaxis=dict(showgrid=False), | ||
| yaxis=dict(showgrid=False), | ||
| fig = go.Figure(data=[ |
There was a problem hiding this comment.
could we put a PX example right above this one plz?
| @@ -35,119 +34,141 @@ jupyter: | |||
| thumbnail: thumbnail/axes.png | |||
| --- | |||
|
|
|||
| This tutorial explain how to set the properties of Cartesian axes, namely [`go.layout.XAxis`](/python/reference/#layout-xaxis) and [`go.layout.YAxis`](python/reference/#layout-xaxis). Other kinds of axes are described in other tutorials: | |||
There was a problem hiding this comment.
nice, this top section is really good!
doc/python/axes.md
Outdated
|
|
||
| fig.show() | ||
| ``` | ||
|
|
||
| #### Tick Placement, Color, and Style | ||
|
|
||
| ##### Set number of tick marks |
There was a problem hiding this comment.
maybe add "(and grid lines)" to reinforce that these are locked together?
|
This is great! OK just two comments, the ones that are not "resolved" after all ;) |
|
I also added an example with log and fixed range. |
|
💃 ... big upgrade, thanks! |
|
Hum I should have branched from doc-prod but I forgot... I guess it does not matter much since we're releasing in a few days? |
|
That’s fine, just merge to master
On Wed, Jan 15, 2020 at 11:57 Emmanuelle Gouillart ***@***.***> wrote:
Hum I should have branched from doc-prod but I forgot... I guess it does
not matter much since we're releasing in a few days?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2068?email_source=notifications&email_token=AABRWA4BPHSBR4I7PRBP3HTQ54553A5CNFSM4KGULETKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBAVNA#issuecomment-574753460>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRWA4BCK7V3STSDH7MV3TQ54553ANCNFSM4KGULETA>
.
--
Nicolas Kruchten-VP Product
Email [email protected]
5555 Gaspe Ave #118, Montreal, QC, H2T 2A3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.Layoutorgo.layout.XAxisconstrain='domain'and another one settingdomain.