Skip to content

Add some comments about the configuration of the legend #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2020

Conversation

WenjieZ
Copy link
Contributor

@WenjieZ WenjieZ commented Jan 5, 2020

Remove "Legend Entries" in the title since it is already in an individual page.

Add some comments about the configuration of the legend.

Remove "Legend Entries" in the title since it is already in an individual page.
@emmanuelle
Copy link
Contributor

Hi @WenjieZ , I would prefer to keep "legend entries" here because setting the name parameter of a trace sets its legend entry. But you're right that this example could be improved by

  • adding an inline comment in the first comment to say that name is used as legend entry
  • and to add sentence mentioning that another page is dedicated to legends, with a link to this page (the link would be /python/legend since we use relative links in the doc).

If you agree with these suggestions, would you have the time to implement it? Thanks anyway, it's very helpful to get feedback and improvements about the doc.

@WenjieZ WenjieZ changed the title Remove "Legend Entries" in the title Add some comments about the configuration of the legend Jan 6, 2020
@WenjieZ
Copy link
Contributor Author

WenjieZ commented Jan 6, 2020

Hi @emmanuelle , let me know whether that modification is good enough.

@emmanuelle
Copy link
Contributor

Great, thanks a lot @WenjieZ ! Merging 💃

@emmanuelle emmanuelle merged commit 0281146 into plotly:doc-prod Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants