Skip to content

Fix anaconda simplejson issue #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2015
Merged

Conversation

theengineear
Copy link
Contributor

Fixes #197

We now have an extras_require mapping to optional dependencies for python 2.6

Just like how you can do:
pip install ipython[notebook]

You can now do:
pip install plotly[PY2.6]
@theengineear
Copy link
Contributor Author

You can test that it works by doing the following in a local copy of this repo (i couldn't get it to work from github)

pip install -e '.[PY2.6]'

I'm using OHMYZSH hence those extras quoties...

@theengineear
Copy link
Contributor Author

@etpinard and @scjody , seem like a reasonable solution?

@etpinard
Copy link
Contributor

I like it. 💃

@theengineear
Copy link
Contributor Author

The normal workflow I'm expecting is this (/dev/null just for brevity below):

$ pip install plotly > /dev/null
$ python -c 'import plotly'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "plotly/__init__.py", line 31, in <module>
    from plotly import plotly, graph_objs, grid_objs, tools, utils, session
  File "plotly/plotly/__init__.py", line 10, in <module>
    from . plotly import (
  File "plotly/plotly/plotly.py", line 35, in <module>
    from plotly import tools
  File "plotly/tools.py", line 22, in <module>
    from plotly.graph_objs import graph_objs
  File "plotly/graph_objs/__init__.py", line 12, in <module>
    from . graph_objs import (
  File "plotly/graph_objs/graph_objs.py", line 29, in <module>
    from plotly.graph_objs import graph_objs_tools
  File "plotly/graph_objs/graph_objs_tools.py", line 12, in <module>
    "Looks like you're running Python 2.6. Plotly expects newer "
ImportError: Looks like you're running Python 2.6. Plotly expects newer standard library versions of ordereddict and json. You can simply upgrade with these 'extras' with the following terminal command:
pip install 'plotly[PY2.6]'
$ pip install 'plotly[PY2.6]'  > /dev/null
$ python -c 'import plotly'
$ 

@scjody
Copy link

scjody commented Feb 27, 2015

sweet, 💃

@scjody
Copy link

scjody commented Mar 5, 2015

This hit another user. Can you 💃 this soon?

@theengineear
Copy link
Contributor Author

@scjody , yup. Thanks!

theengineear added a commit that referenced this pull request Mar 5, 2015
@theengineear theengineear merged commit ce0adcc into master Mar 5, 2015
@theengineear theengineear deleted the fix-anaconda-simplejson-issue branch March 5, 2015 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing simplejson kills pip on anaconda
3 participants