Skip to content

dataframe parameter in px docstrings #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2019
Merged

dataframe parameter in px docstrings #1932

merged 3 commits into from
Nov 29, 2019

Conversation

emmanuelle
Copy link
Contributor

Closes #1926 . Is this enough?

@@ -22,6 +22,7 @@
"DataFrame or array-like or dict",
"This argument needs to be passed for column names (and not keyword names) to be used.",
"Array-like and dict are tranformed internally to a pandas DataFrame.",
"Optional, since a DataFrame gets constructed under the hood using the other arguments."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Optional, since a DataFrame gets constructed under the hood using the other arguments."
"Optional: if missing, a DataFrame gets constructed under the hood using the other arguments."

@nicolaskruchten
Copy link
Contributor

Yup, modulo small fix! 💃

@emmanuelle emmanuelle merged commit f5af9cb into master Nov 29, 2019
@emmanuelle emmanuelle deleted the px-docstrings-df branch December 2, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PX docstrings and data_frame
2 participants