Skip to content

updated subplots import in figure factories #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2019
Merged

updated subplots import in figure factories #1899

merged 1 commit into from
Dec 3, 2019

Conversation

emmanuelle
Copy link
Contributor

No description provided.

@emmanuelle
Copy link
Contributor Author

This issue was noticed in https://community.plot.ly/t/custom-scatterplot-matrix-splom/31243/6

@nicolaskruchten
Copy link
Contributor

Are the functions which this touches under test or...? Is this a bugfix or just cosmetic? I'm OK either way, just curious :)

@emmanuelle
Copy link
Contributor Author

It's only cosmetic, the current code is under test and works.

@nicolaskruchten
Copy link
Contributor

💃

@emmanuelle emmanuelle merged commit e5e1457 into master Dec 3, 2019
@emmanuelle emmanuelle deleted the ff-subplots branch December 3, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmanuelle @nicolaskruchten