Skip to content

PX shouldn't modify attrs controlled by template #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2019
Merged

PX shouldn't modify attrs controlled by template #1875

merged 4 commits into from
Nov 6, 2019

Conversation

nicolaskruchten
Copy link
Contributor

This supersedes #1863

@nicolaskruchten nicolaskruchten mentioned this pull request Nov 5, 2019
Closed
@emmanuelle
Copy link
Contributor

Thanks it looks good to me. I'm glad that creating a go.layout.Template object helps to remove some of the try/except. As we discussed previously, adding a bunch of unit tests here would be great.

@nicolaskruchten
Copy link
Contributor Author

This now supersedes #1871 also

@nicolaskruchten nicolaskruchten mentioned this pull request Nov 5, 2019
Closed
@nicolaskruchten
Copy link
Contributor Author

@emmanuelle ready for re-review! I added a nice little test suite.

@nicolaskruchten nicolaskruchten mentioned this pull request Nov 5, 2019
Merged
6 tasks
emmanuelle
emmanuelle reviewed Nov 6, 2019
View reviewed changes
packages/python/plotly/plotly/tests/test_core/test_px/test_px.py

# special px-level defaults over pio defaults
pio.templates.default = "seaborn"
px.defaults.template = "ggplot2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should document this in https://plot.ly/python/templates/, I did not know this was possible

@emmanuelle
Copy link
Contributor

Thanks for adding this awesome test suite! We might want to merge #1877 first and rebase to have a green CI and benefit from Percy visual inspection, but this looks really good.

@emmanuelle
Copy link
Contributor

💃 once the CI is green

@nicolaskruchten nicolaskruchten merged commit 5830055 into master Nov 6, 2019
@nicolaskruchten nicolaskruchten deleted the px_real_template branch June 19, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelle emmanuelle emmanuelle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolaskruchten @emmanuelle