PX templates should override, not merge into default #1871
Conversation
| @@ -1295,6 +1295,9 @@ def make_figure(args, constructor, trace_patch={}, layout_patch={}): | |||
| # Add traces, layout and frames to figure | |||
| fig.add_traces(frame_list[0]["data"] if len(frame_list) > 0 else []) | |||
| fig.layout.update(layout_patch) | |||
| if "template" in args and args["template"] is not None: | |||
There was a problem hiding this comment.
unexpected indent here (makes the CI fail)
|
Could you add a unit test which would fail with the current behaviour and pass with your PR? |
|
With this modification, what would be the recommended way to create a template copying an existing one but changing a few parameters? Defining the new template in |
|
Re unit-tests: this is basically what the Percy test does, although you don't get to see the "before" :) |
Yes, basically. Right now you have to do this to overwrite, and this PR basically flips this around. |
|
bundled into #1875 with tests |
Right now, passing
template={}to anypxmethod gives strange output: it uses thepio.templates.defaultfor most things but then usespx's internal defaults for colors. This is pretty weird and annoying, and it means that if a user wants to inline any template information, they first have to setpio.templates.defaultto"none", or they have to override the entire default template. Also they can't usetemplate={}, they have to usetemplate="none".I think the behaviour in this PR is better, but I welcome feedback.