Skip to content

Update _chart_types.py #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Update _chart_types.py #1785

merged 1 commit into from
Oct 15, 2019

Conversation

yoonghm
Copy link
Contributor

@yoonghm yoonghm commented Sep 22, 2019

barnorm is default to None instead of ''

barnorm is default to None instead of ''
@yoonghm
Copy link
Contributor Author

yoonghm commented Sep 22, 2019

The default parameter barnorm in bar_polar() should be None, as stated in the document rather than the code. Please review.

@jonmmease
Copy link
Contributor

Hi @yoonghm , thanks for your interest. You're right that plotly.py does not explicitly include the default values of every property, and this is by design. When a property is None on the Python side, this means that that the default will be chosen by the JavaScript library.

Is there a particular problem that you were trying to solve?

@nicolaskruchten
Copy link
Contributor

This seems like a good modification, I can't think of a valid reason for it to be set to "" in bar_polar() and None in histogram().

@nicolaskruchten nicolaskruchten merged commit 5084b35 into plotly:master Oct 15, 2019
@nicolaskruchten
Copy link
Contributor

We should think about adding barnorm to bar() :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants