-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add custom_data argument to px functions #1764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
bf38291
doc for custom data
emmanuelle 3a8f33e
add some comments
emmanuelle 16b0753
add customdata to px functions
emmanuelle b39e460
try to fix tests
emmanuelle a761ee4
make black happy
emmanuelle 466abf7
debug test
emmanuelle 0fbc1fd
more debugging
emmanuelle ab421c2
typo
emmanuelle 8b1317f
still debugging
emmanuelle 8ef1187
Revert "debug test"
emmanuelle 1e2d7d9
Revert "try to fix tests"
emmanuelle f8818b3
Merge branch 'master' into custom_data
emmanuelle edea629
implemented deduplication
emmanuelle 8c5eedd
make black happy
emmanuelle 336cae6
removed index from customdata
emmanuelle da5813e
Merge branch 'master' into custom_data
emmanuelle 4f0f3ae
corrected bug
emmanuelle b8d3bc0
Merge branch 'master' into custom_data
emmanuelle 46b8aad
added test for customdata
emmanuelle 61e8927
blackify
emmanuelle cc3c6ba
addressed Nicolas's comments
emmanuelle 79bcd12
added test
emmanuelle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,6 +111,10 @@ | |
colref_list, | ||
"Values from these columns appear as extra data in the hover tooltip.", | ||
], | ||
custom_data=[ | ||
colref_list, | ||
"Values from these columns are extra data, to be used in widgets or Dash callbacks for example.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe a note that this data is not user-visible, but is included in events emitted by the figure? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
], | ||
text=[colref, "Values from this column appear in the figure as text labels."], | ||
locationmode=[ | ||
"(string, one of 'ISO-3', 'USA-states', 'country names')", | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually a NamedTuple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok