Skip to content

Mapbox raster #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Mapbox raster #1592

wants to merge 3 commits into from

Conversation

hishamkaram
Copy link

This PR include:

  • add Raster Layer(EX: geoserver wms layer)

plotly.js Pull Request Link

@jonmmease
Copy link
Contributor

Hi @hishamkaram, thanks for taking a look at this. The changes you made in this PR won't be necessary because the plotly.validators classes are code generated from the plotly.js schema. So once your changes are accepted into Plotly.js and released they will automatically be available in plotly.py in the following plotly.py release. Thanks!

@jonmmease jonmmease closed this Jun 3, 2019
@jonmmease
Copy link
Contributor

See codegen/validators.py for the validators code generation logic if you're interested in seeing how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hishamkaram @jonmmease