Skip to content

Support specifying default renderer using PLOTLY_RENDERER env variable #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2019

Conversation

jonmmease
Copy link
Contributor

Closes #1559

Support specifying the default renderer using the PLOTLY_RENDERER environment variable. This environment variable is only checked when the renderer_defaults future flag is set.

cc @nicolaskruchten

@nicolaskruchten
Copy link
Contributor

2 questions:

  1. should we temporarily have an environment variable to set things in v4 mode also?
  2. do we need a new renderer for documentation or will defaulting to notebook_connected work for nbconverting notebooks to HTML?

@jonmmease
Copy link
Contributor Author

  1. should we temporarily have an environment variable to set things in v4 mode also?

My first reaction is that this would be a bit too magical. I'm comfortable with changing the renderer based on an external environment variable since rendering is inherently context dependent But turning on v4 mode externally would change the semantics of the code with no trace of why it changed.

  1. do we need a new renderer for documentation or will defaulting to notebook_connected work for nbconverting notebooks to HTML?

notebook_connected should work fine through nbconvert. But adding a custom renderer for docs is certainly an option if we run into a need for it.

@nicolaskruchten
Copy link
Contributor

For 1 I agree in general of course I just through it might make doc writing a bit smoother until the launch :) no big deal either way

@jonmmease jonmmease added this to the v3.10 milestone May 27, 2019
@jonmmease jonmmease merged commit d6665a0 into master May 27, 2019
@jonmmease jonmmease added the V4 label May 29, 2019
@nicolaskruchten nicolaskruchten deleted the enh_1559 branch June 19, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set default renderer with environment variable
2 participants