Skip to content

clean up PyPI metadata #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2019
Merged

clean up PyPI metadata #1480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d751743
clean up PyPI metadata
nicolaskruchten Mar 27, 2019
82708a5
Update maintainer
jonmmease Apr 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
include LICENSE.txt
include README.rst
include README.md
include plotlywidget.json
include versioneer.py
Expand Down
115 changes: 0 additions & 115 deletions README.rst
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[metadata]
description-file = README.rst
description-file = README.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure about the impact of this...

license_file = LICENSE.txt

[bdist_wheel]
Expand Down
15 changes: 9 additions & 6 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def plotly_js_version():


def readme():
with open('README.rst') as f:
with open('README.md') as f:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what's on Github by default and is much more up to date than the one on PyPI

return f.read()


Expand Down Expand Up @@ -391,20 +391,23 @@ def run(self):
use_2to3=False,
author='Chris P',
author_email='[email protected]',
maintainer='Chris P',
maintainer_email='chris@plot.ly',
maintainer='Jon Mease',
maintainer_email='jon@plot.ly',
url='https://plot.ly/python/',
description="Python plotting library for collaborative, "
"interactive, publication-quality graphs.",
project_urls={"Github": "https://github.com/plotly/plotly.py"},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just gets a bit more metadata on the PyPI page to show up automatically

description="An open-source, interactive graphing library for Python",
long_description=readme(),
long_description_content_type="text/markdown",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enables us to use Markdown

classifiers=[
'Development Status :: 4 - Beta',
'Development Status :: 5 - Production/Stable',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're there!

'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Topic :: Scientific/Engineering :: Visualization',
],
license='MIT',
Expand Down