No colors functions in ff utils #1301
Conversation
…new scales being referenced
… in figure_factory.utils.py
There was a problem hiding this comment.
Looks good @Kully,
Last thing, for the color functions that moved from plotly/figure_factory/utils.py to plotly/colors.py, can you add imports to plotly/figure_factory/utils.py so that these functions are still available under plotly/figure_factory/utils.py? I don't think you'll have any problems with dependencies in this direction. Thanks!
Is a simple from colors import X, Y, Z, ... |
|
@Kully, that latter. The goal is that if someone has a script with from plotly.figure_factory.utils import Xit should still import as before. |
…add imports to functions that got moved from utils to colors
|
Review is addressed - ready to merge? |
|
💃 |
* correct PLOTLY_SCALES in utils.py and ensure gantt/scatter work with new scales being referenced * move all colors functions stricktly into colors.py and leave the rest in figure_factory.utils.py * change utils.validate_colorsc_dict to clrs.validate_colors_dict * reference is_sequence in _bullet.py to already existing function in figure_factory/utils.py * add validate_colorscale back to colors.py (accidentally deleted) and add imports to functions that got moved from utils to colors
in favor of #1279
Simply, we are making sure there are no function overlap between
plotly/colors.pyandplotly/figure_factory/utils.pyand all references are updated so all code runs well and smoothly.@jonmmease this ready for a review