Skip to content

remove plotly/colors.py in favour of utils #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed

remove plotly/colors.py in favour of utils #1279

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
08e832e
copy n_colors from colors to utils - update all references to colors.…
Kully Nov 20, 2018
0815790
copy good PLOTLY_SCALES in colors.py to incorrect one in utils ; redi…
Kully Nov 20, 2018
30e228e
fix utils.validate_colors so that plotly colors do not give error
Kully Nov 21, 2018
450bcf6
get tests to work
Kully Nov 22, 2018
098bf3d
add invalidd plotly scales back so tests dont break
Kully Nov 22, 2018
ba55531
move nNumbers import to top of utils.py file
Kully Nov 22, 2018
053a9df
copy convert_colors_to_same_type to utils and redirect uses of that f…
Kully Nov 22, 2018
ebab2c4
add utils module to _trisurf.py so previous commit works well
Kully Nov 22, 2018
2e12e5e
copied convert_colorscale_to_rgb to utils.py and switched references …
Kully Nov 22, 2018
ba714ae
copied convert_dict_colors_to_same_type over to utils from colors module
Kully Nov 22, 2018
360256b
make_colorscale now in utils and all references go to it
Kully Nov 22, 2018
85a92d7
rename test_colors to test_figure_factory_utils
Kully Nov 22, 2018
d671498
moved utils test to test_optional folder
Kully Nov 22, 2018
51d679d
remove colors.py
Kully Nov 23, 2018
8e18756
safely remove colors imports
Kully Nov 23, 2018
6df3de5
all functions in figure_factory.utils.py are tested in test_optional
Kully Nov 23, 2018
768c161
remove commented out test
Kully Nov 23, 2018
9f765b9
add colors.py back
Kully Nov 29, 2018
30cbcdd
only import public variables and methods into plotly.colors
Kully Nov 29, 2018
b6c61c1
move from __future__... import at top of file
Kully Nov 29, 2018
fe26750
correct relative path for utils reference
Kully Nov 29, 2018
22c7599
rebase back to 'remove commented out test' commit where the only work…
Kully Dec 10, 2018
dc81ca2
reverted now to ''make_colorscale now in utils and all references go …
Kully Dec 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plotly/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@
from __future__ import absolute_import

from plotly import (plotly, dashboard_objs, graph_objs, grid_objs, tools,
utils, session, offline, colors, io)
utils, session, offline, io)
from plotly.version import __version__
Loading