Skip to content

Redirect orca process stdout to devnull to prevent write_image deadlock #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Redirect orca process stdout to devnull to prevent write_image deadlock #1262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions plotly/io/_orca.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,10 +1086,6 @@ def shutdown_server():
# Kill parent process
orca_state['proc'].terminate()

# Retrieve standard out and standard error to avoid
# warnings
output, err = orca_state['proc'].communicate()

# Wait for the process to shutdown
child_status = orca_state['proc'].wait()
except:
Expand Down Expand Up @@ -1174,8 +1170,9 @@ def ensure_server():

# Create subprocess that launches the orca server on the
# specified port.
DEVNULL = open(os.devnull, 'wb')
orca_state['proc'] = subprocess.Popen(cmd_list,
stdout=subprocess.PIPE)
stdout=DEVNULL)

# Update orca.status so the user has an accurate view
# of the state of the orca server
Expand Down