This is an incomplete fix, but a reasonable one for now. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, mpl has its own datetime system, where it uses floating point versions of the Gregorian calendar days. My attempt to use ISO formatted date-time strings failed. Therefore, I'm actually manually formatting the time-string based on epoch time after converting from mpl_date -> epoch time. Whew!
|
@etpinard, this is a fix that folks have been asking for. It will support datetime conversion along the x-axis. It needs to be fleshed out to handle more than just lines and could easily be extended to work in the y-axis direction as well. |
Matplotlib's docs state: 'objects are converted to floating point numbers which represent time in days since 0001-01-01 UTC, plus 1.' We convert to epoch time with mpl, so it's safe to assume we've got utc time! http://matplotlib.org/api/dates_api.html#module-matplotlib.dates
|
@msund , this is that datetime fix, fyi. Just needs review and a pip version bump. |
|
Okay, merged in new test fixes from master branch. This should? pass now. @etpinard, it'd be rad to get a thumbs-up? ( i know, i owe you code review for the 1.3.0 stuff! 😸 ) |
|
Looking good, the tests passed, 👯 |
theengineear
added a commit
that referenced
this pull request
Sep 24, 2014
This is an incomplete fix, but a reasonable one for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, mpl has its own datetime system, where it uses floating
point versions of the Gregorian calendar days. My attempt to use
ISO formatted date-time strings failed. Therefore, I'm actually
manually formatting the time-string based on epoch time after
converting from mpl_date -> epoch time. Whew!