Skip to content

ignore divide error in streamline #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2018
Merged

ignore divide error in streamline #1213

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71a02f0
ignore divide error in streamline
Kully Oct 3, 2018
0d17600
revert np error to original after division
Kully Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plotly/figure_factory/_streamline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,7 @@ def get_streamline_arrows(self):
dif_x = arrow_end_x - arrow_start_x
dif_y = arrow_end_y - arrow_start_y

np.seterr(divide='ignore', invalid='ignore')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kully! I'd like to see if we can also restore the original numpy error state. Could we do something like:

orig_err = np.geterr()
np.seterr(divide='ignore', invalid='ignore')
streamline_ang = np.arctan(dif_y / dif_x)
np.seterr(**orig_err)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea. Let's try it.

streamline_ang = np.arctan(dif_y / dif_x)

ang1 = streamline_ang + (self.angle)
Expand Down