incorrect use of mergeWith causing mutation to _fullLayout #1204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the
barpolar
trace in aFigureWidget
I came across an error where certain Python update operations did not result in the expected change to the barpolar trace. After hours of Python/JavaScript debugging I found the source. The lodashmergeWith
operation mutates the first argument and we were treating it as though it did not mutate any of the arguments. The fix is simply to pass an empty object as the first argument (7255511).While debugging, I noticed that the
createDeltaObject
function was sometimes returning a delta object that included property values that were functions. This didn't seem to be causing any problems, but the result ofcreateDeltaObject
is the object that is serialized and sent back to the Python side so it's more consistent to remove these function properties here (1a04fbb).