Fix "'module' object has no attribute 'display'" for old ipython. #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chriddyp , this is a fix for old versions of IPython. If you checkout Streambed's requriements.txt https://github.com/plotly/streambed/blob/master/requirements.txt#L56 You'll find a close-to-home case of this! The display module exists, but isn't automatically loaded upon import of IPython in older versions. |
|
Merging this into master will allow us to skip ahead to the newest version of plotly on streambed. |
|
@etpinard , this is pretty simple, but important. mind taking a peek? |
|
💃 |
theengineear
added a commit
that referenced
this pull request
Sep 18, 2014
Fix "'module' object has no attribute 'display'" for old ipython.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPython doesn't necessarily have this package organization. We're just more explicit about it now.