Skip to content

Python 2.7 incompatibility in the iframe renderer #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
carthurs opened this issue Oct 10, 2019 · 0 comments · Fixed by #1810
Closed

Python 2.7 incompatibility in the iframe renderer #1809

carthurs opened this issue Oct 10, 2019 · 0 comments · Fixed by #1810
Labels
bug something broken

Comments

@carthurs
Copy link
Contributor

Plotly with python 2.7 fails when using the iframe renderer, due to a Python 3 call to os.makedirs with the exist_ok flag.

Minimum failing example:
import plotly.graph_objects as go fig = go.Figure( data=[go.Bar(y=[2, 1, 3])], layout_title_text="A Figure Displayed with the 'png' Renderer" ) fig.show(renderer="iframe")
carthurs added a commit to carthurs/plotly.py that referenced this issue Oct 10, 2019
@carthurs
Fix for plotly#1809 Python 2.7 incompatibility in the iframe renderer
2298fa2
@carthurs carthurs mentioned this issue Oct 10, 2019
Merged
@jonmmease jonmmease added the bug something broken label Oct 15, 2019
jonmmease pushed a commit that referenced this issue Oct 15, 2019
@carthurs @jonmmease
Fix for #1809 Python 2.7 incompatibility in the iframe renderer (#1810)
d7021e8
jonmmease added a commit that referenced this issue Oct 16, 2019
@jonmmease
Python 2 iframe renderer follow-on to #1809 (#1822)
d43331a 
* Revert back to makedirs with exist_ok in codegen since this is already Python 3 only
* Follow the Python 3 makedirs implementation by checking isdir rather than errno
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #1809 Python 2.7 incompatibility in the iframe renderer carthurs/plotly.py
2 participants
@carthurs @jonmmease