Skip to content

Presentation template should not change colors #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjaminjack opened this issue Oct 7, 2019 · 1 comment · Fixed by #1819
Closed

Presentation template should not change colors #1807

benjaminjack opened this issue Oct 7, 2019 · 1 comment · Fixed by #1819
Labels
bug something broken

Comments

@benjaminjack
Copy link

Issue

If you combine the 'presentation' template with another template using the plus-sign (+) composition syntax, the presentation template will change the colors of points, lines, and other traces that are defined in the other template.

plotly==4.1.1

Expected behavior

The 'presentation' template should only change the size of text, points, and lines. It should not change the colors.

Reprex

import plotly.express as px

iris = px.data.iris()

# Colors correctly follow the 'plotly_dark' theme
dark_plt = px.scatter(iris, x='sepal_length', y='sepal_width', color='species', template='plotly_dark')
dark_plt.show()

# 'presentation' template changes colors from 'plotly_dark' theme when it shouldn't
dark_pres_plt = px.scatter(iris, x='sepal_length', y='sepal_width', color='species', template='plotly_dark+presentation')
dark_pres_plt.show()
@jonmmease
Copy link
Contributor

Thanks a lot for the report @benjaminjack, fixed in #1819 and will be released in version 4.2.0 in the next few days.

@jonmmease jonmmease added the bug something broken label Oct 15, 2019
jonmmease added a commit that referenced this issue Oct 15, 2019
* Allow pio.template[] to lookup flaglist of templates, fixes #1807
* Fix fig.update to update layout with string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants