Skip to content

Streamtube #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 19, 2019
Merged

Streamtube #124

merged 4 commits into from
Sep 19, 2019

Conversation

emmanuelle
Copy link
Contributor

Doc upgrade checklist:

  • random seed is set if using random data
  • file has been moved from unconverted/x/y.md to x/y.md
  • old boilerplate at top and bottom of file has been removed
  • Every example is independently runnable and is optimized for short line count
  • no more plot() or iplot()
  • graph_objs has been renamed to graph_objects
  • fig = <something> call is high up in each example
  • minimal creation of intermediate trace objects
  • liberal use of add_trace and update_layout
  • fig.show() at the end of each example
  • px example at the top if appropriate
  • minimize usage of hex codes for colors in favour of those in https://github.com/plotly/plotly.py-docs/issues/14

@emmanuelle
Copy link
Contributor Author

Note that further improvements of the streamtube plot should probably wait until plotly/plotly.js#4206 is solved.

nicolaskruchten
nicolaskruchten reviewed Sep 19, 2019
View reviewed changes
python/streamtube-plot.md Outdated
```

#### Reference
See https://plot.ly/python/reference/ for more information and chart attribute options!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you link directly to the trace docs plz? i.e. add the #streamtube at the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes sure

@nicolaskruchten
Copy link
Contributor

💃

@emmanuelle emmanuelle merged commit b8e8088 into master Sep 19, 2019
@emmanuelle emmanuelle deleted the streamtube branch September 19, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaskruchten nicolaskruchten nicolaskruchten left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmanuelle @nicolaskruchten