Skip to content

ternary contour notebook #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 4, 2019
Merged

ternary contour notebook #107

merged 5 commits into from
Sep 4, 2019

Conversation

emmanuelle
Copy link
Contributor

New notebook for recent figure factory.

@emmanuelle
Copy link
Contributor Author

Should we also keep the example of https://plot.ly/python/ternary-contour/?

@nicolaskruchten
Copy link
Contributor

Sorry this dropped off my radar! I think this notebook should replace the existing one, which doesn't actually do contours.

You will probably need to rebase this PR onto master and update requirements.txt to include scikit-image so that CI will pass :)

thanks!

@nicolaskruchten
Copy link
Contributor

@emmanuelle can we try to revive this PR too please?

@nicolaskruchten
Copy link
Contributor

The build is failing, and the output is in the "artifacts" under "failures": https://209-189674195-gh.circle-artifacts.com/0/build/failures/ternary-contour

@nicolaskruchten
Copy link
Contributor

If you could rebase this onto master, it would clean up the commit history a bit :) We're big rebasing fans in general at Plotly (except in the Plotly.js repo)

@emmanuelle
Copy link
Contributor Author

yes it looks better :-)

@emmanuelle
Copy link
Contributor Author

The discrepancies you found came from the fact that I had started a new file from scratch, I had forgotten that a stub already existed

@nicolaskruchten
Copy link
Contributor

💃 !

@emmanuelle emmanuelle merged commit 9efb356 into master Sep 4, 2019
@emmanuelle emmanuelle deleted the ternary-contour branch September 4, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants