-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Slider component #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Slider component #986
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
f5bccd5
First cut at slider
rreusser 83483fd
Fix lint errors in slider
rreusser f69a328
Add slider transitions
rreusser 82ea558
Expand touchable slider area
rreusser ca5f9f5
Add slider mock
rreusser c6a3e11
Rename sliders and bump circular require tolerance
rreusser 5b74652
Add trbl padding to sliders
rreusser e13e0ee
Remove fanciness from slider constants
rreusser 8fe1842
Tweak slider behavior to avoid event -> method loops
rreusser 05ac586
Improve padding logic for updatemenus
rreusser 4604341
Add jasmine tests for updatemenus padding
rreusser 8558be8
add streaming maxpoints max and dflt
cldougl c673afe
Merge pull request #996 from plotly/maxpt_dflt
cldougl 304174a
Add current value output to sliders
rreusser fce36fa
Merge pull request #989 from plotly/fix-updatemenus-padding
rreusser 52b4a2a
First cut at slider
rreusser b161d55
Fix lint errors in slider
rreusser 8d7c40d
Add slider transitions
rreusser 30b5f2d
Expand touchable slider area
rreusser 19442d9
Add slider mock
rreusser ecb7e87
Rename sliders and bump circular require tolerance
rreusser 9c0f9ac
Add trbl padding to sliders
rreusser 2a6f987
Remove fanciness from slider constants
rreusser 5bd6bdd
Tweak slider behavior to avoid event -> method loops
rreusser 4520a48
Add current value output to sliders
rreusser 88d6728
Tweak slider colors
rreusser 6da5b0f
Fix sliders in plot schema
rreusser 1cad8a4
Merge branch 'slider-component' of github.com:plotly/plotly.js into s…
rreusser 4a9edd0
Working through slider testing issues
rreusser 6cb6d42
Add slider tests
rreusser 4775a47
Test updateevent for sliders
rreusser a08f084
Update sliders baseline to reflect bugfix
rreusser 5816c24
Fix plot schema error
rreusser 2cfa81b
Remove unneeded lines from sliders test
rreusser 1d52b51
Remove updatevalue and updateevent
rreusser 892583d
Removed unused slider function
rreusser 5015710
Clean up slider options
rreusser 582c643
Remove unneeded/failing slider test
rreusser 70610ec
Add suffix to currentvalue slider label
rreusser f25127c
don't coerce slider currentvalue attrs when !visible
rreusser 4b608ee
Be more specific about *all* unused slider attrs not set
rreusser 6c9034d
Test mouse movement for sliders
rreusser 21e2f99
Make sure slider Drawing.bBox calls fall back to defined
rreusser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. That's all I wanted. Thanks for taking the time to do this 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No prob. Wasn't too bad; just hadn't previously tried mocking mouse events and positions.