Lock gl-shader to 4.2.0 #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- gl-pointcloud2d will still use [email protected], but every other module will use 4.2.0
|
cc @monfera |
|
cc @dfcreative It would be nice to use one and only one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes (temporary) #929
The patches made in stackgl/gl-shader#16 broke some of our gl3d functionality - which unfortunately did not get caught by our CircleCI tests.
As this is a pretty significant regression, I offer this temporary solution where we lock
gl-shaderto4.2.0so that afternpm i && npm dedupewe get:meaning that all packages requiring
gl-shaderexcept forgl-pointcloud2dwill get4.2.0whereasgl-pointcloud2dwill get4.2.1.In the future, we should attempt to find a solution in
gl-sharderthat both supports the (new) requirements forgl-pointcloud2dand our (old) gl3d requirements.