Special mapboxAccessToken case for Atlas users #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- setting mapboxAccessToken to '', guarantees that plotly.js will not attempt to make request to the public mapbox server regardless of what layout.mapbox.accesstoken is set to.
| 'See https://www.mapbox.com/developers/api/#access-tokens' | ||
| ].join(' '); | ||
|
|
||
| Plotly.plot(gd, [{ |
There was a problem hiding this comment.
Hmm, because there's an error thrown we can't catch yr '' return from plot, right?
There was a problem hiding this comment.
Edit, ^^ sorry, that doesn't make sense. Ignore.
|
Cool! |
etpinard
added a commit
that referenced
this pull request
Sep 8, 2016
Special mapboxAccessToken case for Atlas users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that plotly.js does not attempt to reach the mapbox public server when users are connected to a Mapbox Atlas server.