Fix update menu 'yanchor' default #894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 'bottom' -> 'top' - 'bottom' was misplaced in #770 when the attributes were ported over from range selectors
|
cc @rreusser |
|
Thanks! Scrolling will also help the remaining surprises. I wonder if we can generalize an internal scrolling component. |
I'm sure we could. But, it's not a super high priority item for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the updatemenus
yanchordefault value from'bottom'->'top'essentially fixing #890The value
'bottom'was misplaced in #770 when the attributes were ported over from range selectors'. Having the update menu dropdown drop from the top of the plot area is desired behavior.