Add global transforms config option #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that transform can use fullTrace._input, index and _expandedIndex
- transform options can be specified using the config arg or globally using Plotly.setPlotConfig() - global transforms are applied to all traces and are supplied before all other trace transforms.
| filtersrc: 'x' | ||
| }, '- trace second'); | ||
| }); | ||
|
|
There was a problem hiding this comment.
looks great!
What do you think about one additional test that ensures transforms have access to fullTrace._input user data? Just in case someone other than yourself decides to refactor one day and accidentally breaks a bunch of userspace transforms.
|
looks great, one 🐅 question but otherwise 💃 |
- Plots.supplyDefaults({data: [], layout: {}}) should work always!
| expect(dataOut[0]._input).toBe(dataIn[0]); | ||
| expect(opts.transform).toBe(transformOut); | ||
| expect(opts.fullTrace._input).toBe(dataIn[0]); | ||
| expect(opts.layout).toBe(layout); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that users can now set transform globally for all traces going through
Plotly.plot.Example:
cc @bpostlethwaite