Non-scaling SVG scatter lines #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rreusser
changed the title
|
Nicely done 💃 |
|
Awesome! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #760
See related point scaling PR: #762
See codepen example (includes point scaling PR, visible on scrollZoom): http://codepen.io/rsreusser/pen/OXvmjR?editors=0010
This is basically a one-line commit that disables scaling on scatter paths. It can be applied in
lineGroupStyle, but since it has no effect in the other places where it's used (except for contours, where this could also be applied), it seems more targeted to just apply it to scatter lines directly.This does not solve the point scaling problem. See example at: https://rreusser.github.io/plotly-expression-transform/ (which actually applies it in the drawing component, but for the sake of illustration, the effect is the same while scrollzoooming)
cc: @mdtusz