Use correct parent document when necessary: fixes 702 #2 #758

Closed

nielsenb-jf wants to merge 115 commits intoplotly:masterfrom

nielsenb-jf:child_window_fixes

Commits on Jul 12, 2016

Commits on Jul 13, 2016

Commits on Jul 14, 2016

Merge branch 'master' into child_window_fixes
nielsenb-jf
committed
Only inject Plotly CSS into the document a plot is being rendered in.
nielsenb-jf
committed
Don't hardcode CSS in plotcss_injector, instead use the generated style
nielsenb-jf
committed

Commits on Jul 15, 2016

Commits on Jul 20, 2016

bump karma to 1.1.0

etpinard
authored and
nielsenb-jf
committed
bump eslint to 3.0.0

etpinard
authored and
nielsenb-jf
committed
bar: set marker.line.width dflt to 0

etpinard
authored and
nielsenb-jf
committed
test: add bargap 0 mock

etpinard
authored and
nielsenb-jf
committed
test-runner: check if baseline img exist before px comparison

etpinard
authored and
nielsenb-jf
committed
Ensure the dragcover is rendered on the proper element.
nielsenb-jf
committed
Be consistent with use of ownerDocument.
nielsenb-jf
committed
bar: skip over bars with non-numeric size in setPositions

etpinard
authored and
nielsenb-jf
committed
test: add stack with gaps mock

etpinard
authored and
nielsenb-jf
committed
test-assets: add msg-extra argument to is-close array matchers

etpinard
authored and
nielsenb-jf
committed
test-assets: don't try to compute dist between non-numeric elements

etpinard
authored and
nielsenb-jf
committed
lint: flatten bar test suite

etpinard
authored and
nielsenb-jf
committed
test: add bar calc / setPositions tests

etpinard
authored and
nielsenb-jf
committed
fix issue with bar releative mode when first bucket is 0 or string

keeganmccallum
authored and
nielsenb-jf
committed
lint: bar setPositions comments + spaces

etpinard
authored and
nielsenb-jf
committed
test: add bar setPositions test cases for relative of pos 0 / -0

etpinard
authored and
nielsenb-jf
committed
Memory leak fix candidates: 1) purge must destroy scene2d otherwise rAF never stops; 2) scene2d.destroy should destroy the traces

monfera
authored and
nielsenb-jf
committed
Lint

monfera
authored and
nielsenb-jf
committed
Call cleanPlot from newPlot directly; Changed the location of the trace dispose loop; null -> delete

monfera
authored and
nielsenb-jf
committed
Adding test cases that check that Plotly.newPlot indeed causes dereferencing of the GL context or its own canvas

monfera
authored and
nielsenb-jf
committed
lint: sub this -> self

etpinard
authored and
nielsenb-jf
committed
mapbox: emit plotly_relayout event mouse move

etpinard
authored and
nielsenb-jf
committed
lint: flattern Fx test suite

etpinard
authored and
nielsenb-jf
committed
update 'dragmode' cursor in relayout NOT modebar

etpinard
authored and
nielsenb-jf
committed
dry: check for if dragbox is main-drag only once

etpinard
authored and
nielsenb-jf
committed
fixup flatten

etpinard
authored and
nielsenb-jf
committed
fx: make mainDrag active if 'lasso' / 'select' even w/ fixed ranges

etpinard
authored and
nielsenb-jf
committed
test: check main drag update on relayout

etpinard
authored and
nielsenb-jf
committed
Reifies not yet covered, preexisting behavior of Lib.extendDeep to check correctness of the speedup

monfera
authored and
nielsenb-jf
committed
update changelog for v1.14.2

etpinard
authored and
nielsenb-jf
committed
1.14.2

etpinard
authored and
nielsenb-jf
committed
Speed up Lib.extendDeep (_extend) for primitive arrays

monfera
authored and
nielsenb-jf
committed
fix gl2d snapshot rendering

mikolalysenko
authored and
nielsenb-jf
committed
lint

etpinard
authored and
nielsenb-jf
committed
Bypassing most of the heavy lifting in the rAF for when there's no user interaction

monfera
authored and
nielsenb-jf
committed
Use trace.uid rather than hanging on to the entire trace just for the lastPickResults

monfera
authored and
nielsenb-jf
committed
test: make convertToTspans suite more robust

etpinard
authored and
nielsenb-jf
committed
lib: handle '=' and '&' in anchor href

etpinard
authored and
nielsenb-jf
committed
test: add tests for XSS attack in text href

etpinard
authored and
nielsenb-jf
committed
Queue length limitation concept

monfera
authored and
nielsenb-jf
committed
Lint away queue length logging

monfera
authored and
nielsenb-jf
committed
lint: no need to check for Plotly.Queue existence

etpinard
authored and
nielsenb-jf
committed
lib: use queue length set via setPlotConfig

etpinard
authored and
nielsenb-jf
committed
test: add test for queue

etpinard
authored and
nielsenb-jf
committed
lib: make sure queueObj exist before trying to unshift it

etpinard
authored and
nielsenb-jf
committed
Ensure range sliders use the correct child document / window.
nielsenb-jf
committed
Properly resize plot based on plot parent window.
nielsenb-jf
committed
add Lib.validate function:

etpinard
authored and
nielsenb-jf
committed
make is-valid colorscale array more strict

etpinard
authored and
nielsenb-jf
committed
make string val type more strict:

etpinard
authored and
nielsenb-jf
committed
add a few test cases for coerce + 'info_array'

etpinard
authored and
nielsenb-jf
committed
add validateFunction for info_array

etpinard
authored and
nielsenb-jf
committed
make 'dflt' a required opts for 'subplotid' val types

etpinard
authored and
nielsenb-jf
committed
add validate function for 'subplotid' val types

etpinard
authored and
nielsenb-jf
committed
add Plotly.validate:

etpinard
authored and
nielsenb-jf
committed
validate: add support for is isSubplotObj attributes

etpinard
authored and
nielsenb-jf
committed
validate: add 'container' error code

etpinard
authored and
nielsenb-jf
committed
on 2nd thought, only coerce numbers to strings

etpinard
authored and
nielsenb-jf
committed
clean up is-valid-colorscale logic

etpinard
authored and
nielsenb-jf
committed
make info_array validate func more strict:

etpinard
authored and
nielsenb-jf
committed
validate: flatten Plotly.validate output

etpinard
authored and
nielsenb-jf
committed
Only inject Plotly CSS into the document a plot is being rendered in.
nielsenb-jf
committed
Don't hardcode CSS in plotcss_injector, instead use the generated style
nielsenb-jf
committed
When injecting styles, don't inject a duplicate selector.
nielsenb-jf
committed
Don't keep a reference to the stylesheet in lib.
nielsenb-jf
committed
Add a z-index to js-plotly-tester as a workaround for a chrome bug (#513)

Ben Jeffery
authored and
nielsenb-jf
committed
Make injectStyles take the graph div (gd) as the argument.
nielsenb-jf
committed
Move addStyleRule code to injectStyles, delete lib.addStyleRule.
nielsenb-jf
committed
Only injectStyles if they haven't already been injected.
nielsenb-jf
committed
Graph div now keeps a _document reference to the document it's rendered in.
nielsenb-jf
committed
scattermapbox: override hash item if undefined (in case === 0)

etpinard
authored and
nielsenb-jf
committed
Make sure graph div _document property is set for drag element tests.
nielsenb-jf
committed
Add some tests to make sure CSS injection is happening correctly.
nielsenb-jf
committed
Move some common code to a helpers file so they can be used in tests.
nielsenb-jf
committed
Use CSS helper functions.
nielsenb-jf
committed
Move CSS injection tests to plt_css_test.js.
nielsenb-jf
committed
Use @src and @build macros.
nielsenb-jf
committed
Cleanup _document and _plotCSSLoaded in plots.purge.
nielsenb-jf
committed
Notifier now requires a graph div as the first argument.
nielsenb-jf
committed
Add issue and pr template from CONTRIBUTING.md

rreusser
authored and
nielsenb-jf
committed
Fix naming of PR template

rreusser
authored and
nielsenb-jf
committed
Actually include the PR template

rreusser
authored and
nielsenb-jf
committed
Guideline cleanup

rreusser
authored and
nielsenb-jf
committed
Punctuation detail

rreusser
authored and
nielsenb-jf
committed
When injecting styles, don't inject a duplicate selector.
nielsenb-jf
committed
Don't keep a reference to the stylesheet in lib.
nielsenb-jf
committed
Merge branch 'child_window_fixes' into child_css
nielsenb-jf
committed
Fix formatting.
nielsenb-jf
committed
Merge branch 'child_window_fixes' into child_css
nielsenb-jf
committed
Make injectStyles take the graph div (gd) as the argument.
nielsenb-jf
committed
Move addStyleRule code to injectStyles, delete lib.addStyleRule.
nielsenb-jf
committed
Only injectStyles if they haven't already been injected.
nielsenb-jf
committed
Graph div now keeps a _document reference to the document it's rendered in.
nielsenb-jf
committed
Merge branch 'master' into child_window_fixes
nielsenb-jf
committed
Make sure graph div _document property is set for drag element tests.
nielsenb-jf
committed
Add some tests to make sure CSS injection is happening correctly.
nielsenb-jf
committed
Move some common code to a helpers file so they can be used in tests.
nielsenb-jf
committed
Use CSS helper functions.
nielsenb-jf
committed
Move CSS injection tests to plt_css_test.js.
nielsenb-jf
committed
Use @src and @build macros.
nielsenb-jf
committed
Notifier now requires a graph div as the first argument.
nielsenb-jf
committed
Cleanup _document and _plotCSSLoaded in plots.purge.
nielsenb-jf
committed
Merge branch 'notifier_fixes' into child_window_fixes
nielsenb-jf
committed
Merge branch 'master' into child_window_fixes
nielsenb-jf
committed
Merge branch 'child_window_fixes' of github.com:nielsenb-jf/plotly.js into child_window_fixes
nielsenb-jf
committed