Move css-loader and others into devDependencies #7407
+179
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to not install css-loader and its dependencies during a `npm install plotly.js`, turn them into devDependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some recent PRs (#7142, #7140) introduced the
css-loader,style-loaderandesbuild-style-pluginas dependencies. However it seems that they should be categorized as devDependencies instead, because they don't end up in the bundle, but are used to create the bundle.This poses a problem for me, as it causes
npm install plotly.jsto install significantly more dependencies than necessary.In order to not install css-loader and its dependencies during a
npm install plotly.js, turn them into devDependencies.