Skip to content

Set undo/redo queue length via setPlotConfig #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 12, 2016
Merged

Set undo/redo queue length via setPlotConfig #737

merged 6 commits into from
Jul 12, 2016

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Jul 11, 2016 •
edited
Loading

In brief this PR,

  • starts off by cherry-picking @monfera's commits from [concept] Queue length limit #726
  • lints a few things,
  • makes the queue length configurable via a new queueLength config option
  • and adds a few tests for Queue

monfera and others added 5 commits July 11, 2016 17:11
@monfera @etpinard
Queue length limitation concept
a8d314d 
(cherry picked from commit e07f91d)
@monfera @etpinard
Lint away queue length logging
e1786dc
@etpinard
lint: no need to check for Plotly.Queue existence
8a141ea 
- use Lib not Plotly.Lib in queue.js
- some space pads
- fix typo in plot_config.js comment
@etpinard
lib: use queue length set via setPlotConfig
a494a89 
- use a default of 0 (i.e. turned off the queue by default)
@etpinard
test: add test for queue
75c8465
@etpinard etpinard mentioned this pull request Jul 12, 2016
Closed
@etpinard
Copy link
Contributor Author

@bpostlethwaite would you mind reviewing this PR at some point this week?

@bpostlethwaite
Copy link
Member

great! 💃

@etpinard etpinard merged commit ead4bc5 into master Jul 12, 2016
@etpinard etpinard deleted the config-queue-length branch July 12, 2016 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etpinard @bpostlethwaite @monfera