Fix failing noCI tests #7343
Draft
Fix failing noCI tests #7343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilykl
force-pushed
the
fix-deprecated-tests
branch
from
8c7fc12 to
39520c1
Compare
…ly.js into fix-deprecated-tests
gvwilson
added
P1
archmoj
reviewed
Mar 31, 2025
| gd = createGraphDiv(); | ||
| return Plotly.newPlot(gd, _mock); | ||
| }) | ||
| .then(delay(100)) |
There was a problem hiding this comment.
Thank you @emilykl for the PR.
Instead of removing these tests, could you adjust the delay after the first plot? Also you may be able to remove @noCI tag and it start working on the CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix / modify / remove
@noCItests which are failing