Make mapbox access token configurable via layout attribute

[etpinard]

@chriddyp

In brief

Users can now register their mapbox access token via layout.mapbox.accesstoken:

var layout = {
  mapbox: {
    accesstoken: 'pk.124faEdgfsar2wsasdfsdgradgafdgasd'
  }
};

This is especially important for users wanting to use a custom map style - where setting the access token in layout guarantee that the map will look the same regardless of the specified config options.

If mapbox.accesstoken isn't specify, the config mapboxAccessToken is used.

[etpinard]

@chriddyp Important Setting a wrong access token currently:

• throws an error,
• clears the map, and
• does not update fullLayout.mapbox.accesstoken

Is this something you can work with the workspace? If not, please let me know. Alternatively, we could:

1. as the above, but clear fullLayout.mapbox.accesstoken if it is invalid
2. eat up the error ...
3. anything else?

Note also that setting an invalid mapbox.style does essentially the same.

[lpan]

@chriddyp @etpinard one thing we can do is to make our token validation impeccable (maybe validate our token against the real mapbox api endpoint). @BRONSOLO has opened an issue about it https://github.com/plotly/streambed/issues/7010. For now in my opinion when the user supplies a bad token/style we catch the error then pop up an error dialogue telling them what is going on.

[etpinard]

@lpan So, what are you proposing?

one thing we can do is to make our token validation impeccable

I'd vote 👎 for adding token validation in plotly.js. Making one request to validate the token and then one to plot the map sounds like an overkill. No?

For now in my opinion when the user supplies a bad token/style we catch the error then pop up an error dialogue telling them what is going on.

... as currently off this branch, correct?

[lpan]

I'd vote 👎 for adding token validation in plotly.js. Making one request to validate the token and then one to plot the map sounds like an overkill. No?

No no no 😛 I meant when the user add a mapbox token in setting. our backend makes a request to the mapbox to validate the token. If it is not valid, they cant even add the token. So we are sure that all of the tokens in the the token dropdown are valid

[lpan]

... as currently off this branch, correct?

yep

[etpinard]

@lpan Thanks for the clarification!

[lpan]

💃 👍