Skip to content

make offsetgroup work with barmode 'stacked' and 'relative' for bar traces #7247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

make offsetgroup work with barmode 'stacked' and 'relative' for bar traces #7247

wants to merge 23 commits into from

Conversation

stephprobst
Copy link

Continuation of PR #7009 due to temporary unavailability of original author.

Last changes:

  • Rebased PR on master.

my-tien and others added 23 commits October 22, 2024 16:17
@my-tien @stephprobst
For bar traces make offsetgroup work with barmode 'stacked' and 'rela…
a3fbabf 
…tive'
@my-tien @stephprobst
Fix handleGroupingDefaults calls outside of bar/defaults.js
16cb035
@my-tien @stephprobst
Fix linter error on missing newline at EOF
3f3a30e
@my-tien @stephprobst
Fix offset calculation and stacking for barpolar
bdce78a 
barpolar trace has no offsetgroup property
@my-tien @stephprobst
Fix angularaxis check in setOffsetAndWidth
c0d3216
@my-tien @stephprobst
consider modes of other traces as well (scattermode, funnelmode,... )
9ae2c10
@my-tien @stephprobst
Don't use poffset for sieve.put, use trace._offsetIndex instead.
eb101ff 
poffset is not only different for different offsetgroups but also when the trace has a different width.
@my-tien @stephprobst
Fix logic for adding a gap between bars
641a544
@my-tien @stephprobst
baseline image for zzz_bar_relative_offsetgroup
8f020f6
@my-tien @stephprobst
Fix sieve for offsetgroups
a4fde80 
Previous attempt that used bar.p + offsetIndex resulted in the same bin for a bar with bar.p 0 and offsetIndex 1 and a bar with bar.p 1 and offsetIndex 0
@my-tien @stephprobst
Fix for failing baseline test waterfall_funnel_template_date
48c469e
@my-tien @stephprobst
Pass missing barmode param for histogram
31bb43a
@my-tien @stephprobst
Ensure offsetIndex and offsetgroup are not undefined
81450bd
@my-tien @stephprobst
Track alignmentgroups in fullLayout._alignmentOpts by trace type
3817206 
Previously, all offsetgroups of different trace types were listed together, leading to undesired grouping interaction between different trace types.

Fixes failing baseline test "legendgroup".
@my-tien @stephprobst
Make offsetgroup work for boxmode overlay as well
3ec003d
@my-tien @stephprobst
Documentation for setOffsetAndWidth and fix for sieve documentations
3830b94
@my-tien @stephprobst
Revert "Make offsetgroup work for boxmode overlay as well"
5faf455 
This reverts commit ac93f5d.
@my-tien @stephprobst
Revert "Track alignmentgroups in fullLayout._alignmentOpts by trace t…
ea23867 
…ype"

This reverts commit e8bd5db.
@my-tien @stephprobst
Ignore offsetgroup and alignmentgroup for those trace types that don'…
28b81a1 
…t have a mode "stack", i.e. scatter, box, violin, waterfall
@my-tien @stephprobst
Update funnel test after adding support for alignmentgroup and offset…
9601710 
…group for stackable traces
@my-tien @stephprobst
Update bar test after adding support for alignmentgroup and offsetgro…
e6445ba 
…up for stackable traces
@my-tien @stephprobst
Update baseline images for legendgroup_bar-stack and funnel_attrs
d291aad
@stephprobst
Adds draftlog.
3ce0778
@stephprobst stephprobst mentioned this pull request Oct 22, 2024
Merged
@archmoj archmoj closed this Oct 22, 2024
@stephprobst stephprobst deleted the barmode_relative_offsetgroup branch October 22, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephprobst @archmoj @my-tien