-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix lower zorder traces behing some gridlines on overlayed suplots #7171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/image/baselines/zorder-overlayed-subplots-multiple-traces-main-subplot.png
Show resolved
Hide resolved
@my-tien and @stephprobst Please use this bundle to test this within your system and let us know. |
@stephprobst @my-tien were you able to test this bundle? https://output.circle-artifacts.com/output/job/07ec9652-70cc-4287-bfb0-c639ea6b2d39/artifacts/0/dist/plotly.min.js |
@archmoj - I'm out of office and won't be able to test the package before the end of the week. Same for My-Tien. |
Hi @stephprobst @my-tien |
@archmoj: Sorry for the delay in testing. I finally got around to it. The issue with the gridlines seems to be resolved, but we have a similar situation with the tick labels. Here is a codepen displaying the problem: https://codepen.io/Djeramon/pen/RwzvXQX What it looks like in the new test version: From my understanding, tick labels and ticks should always be drawn on top of the traces, correct? |
@archmoj: I just noticed, that there is no issue tracking this work anymore. Should I create one? Or will you take care of that? Thanks! |
The inside tick label edge is tracked in #7227. |
Supersedes #7149.
Here is a minimal code change compared to the rather complex solution proposed in #7149 and avoids several potential side effects catch by tests.
Fixes #7144 thanks to debugging sessions with @emilykl and @gvwilson
@plotly/plotly_js
@bpostlethwaite
@stephprobst
@my-tien