Fix bargap 0 bug #709
Merged
Fix bargap 0 bug #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that plotting code - which relies on marker.line.width to set the effective 'bargap' does not error out - broken since #124
| @@ -15,6 +15,19 @@ var extendFlat = require('../../lib/extend').extendFlat; | |||
| var scatterMarkerAttrs = scatterAttrs.marker; | |||
| var scatterMarkerLineAttrs = scatterMarkerAttrs.line; | |||
|
|
|||
| var markerLineWidth = extendFlat({}, | |||
| scatterMarkerLineAttrs.width, { dflt: 0 }); | |||
|
Good to get this finally fixed. 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #708
Bar traces with
layout.bargap: 0and unsetmarker.line.widthhave been broken since #124 back inv1.3.0(oof) when theBartrace module got split up into separate files.More specifically, when this line got moved to this line without its default overriding argument made the effective line width in the plot step a
NaN(see here).This PR fixes this bug by correctly setting the
marker.line.widthdefault value to0in the bar attributes (note that the scattermarker.line.widthattribute does not have adfltvalue in its attribute s as it depends on whether or not the trace has bubbles - see here)