Skip to content

improve amdefine and requirejs against an empty object #6906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2024
Merged

improve amdefine and requirejs against an empty object #6906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tasks/test_amdefine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ if(typeof define !== 'function') {
define(function(require) {
var plotly = require('../dist/plotly.min.js');

if(plotly) {
if(plotly && plotly.PlotSchema) {
console.log(plotly);
} else {
throw 'Error: loading with amdefine';
Expand Down
2 changes: 1 addition & 1 deletion tasks/test_requirejs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ requirejs.config({

requirejs(['plotly'],
function(plotly) {
if(plotly) {
if(plotly && plotly.PlotSchema) {
console.log(plotly);
} else {
throw 'Error: loading with requirejs';
Expand Down