Miscellaneous mapbox tweaks #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to skip over test the require a gl context, if gl isn't supported - allows us to run _some_ mapbox tests on CircleCI
- so that Point geojson can be displayed as mapbox circle layers - change layer attribute to be more one-to-one with the mapbox api, where styles of different layer types will be set in different container objects
|
|
bingo 💥 |
| 'Sets the circle color.', | ||
| 'Has an effect only when `type` is set to *circle*.' | ||
| ].join(' ') | ||
| } |
There was a problem hiding this comment.
|
💃 looks good to me! |
- it can lead to error in the case where mapbox doesn't have to requested font.
| 'If `type` is *line*, color corresponds to the line color', | ||
| 'If `type` is *fill*, color corresponds to the fill color', | ||
| 'If `type` is *symbol*, color corresponds to the icon color' | ||
| ].join(' ') |
- staying safe as some type change lead to exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chriddyp please review.
What this PR adds
mapbox.layerstypes ➡️'circle'and'symbol'(along side the current'fill'and'line'). This allows GeoJSON point geometries to be drawn as mapboxcircleor symbol layers.glcontext are now tested on CircleCI. So that hot fixes like 9c72548 won't be needed again. See 4a8563b for more.What this PR modifies
mapbox.layersattribute changed a little. They are now more one-to-one with the mapbox layer specs where each layertypegets a container object of its own to fill in style attribute. Note that color in inherited from container to container. See 32973fc for more details.mapbox.layers[i].typedefault is now'circle'. So that even Point GeoJSON can be seen with the default layer type.mapbox.layers[i].coloris now set layer-wide. It corresponds to the primary color of the layer regardless of its type.What this PR fixes
typeto'fill'c1cd50c