Skip to content

Fix layout images add / remove #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2016
Merged

Fix layout images add / remove #672

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25e7459
images: add index to key function
etpinard Jun 20, 2016
badc4e1
test: add add/remove layout image test
etpinard Jun 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/images/draw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,8 @@ module.exports = function draw(gd) {


// Required for updating images
function keyFunction(d) {
return d.source;
function keyFunction(d, i) {
return d.source + i;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdtusz does this look right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe we give all _isLinkedToArray (e.g. annotations, shapes, image, mapbox layers) containers a uid?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be sufficient.

}


Expand Down