Skip to content

do not run stamen-watercolor tests on CI for now #6649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023
Merged

do not run stamen-watercolor tests on CI for now #6649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions test/image/compare_pixels_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,15 @@ argv._.forEach(function(pattern) {
}
});

// skip for now | TODO: figure out why needed this in https://github.com/plotly/plotly.js/pull/6610
allMockList = allMockList.filter(function(a) { return a !== 'mapbox_custom-style';});
allMockList = allMockList.filter(function(a) {
return (
// used to pass before 2023 Jun 20
a !== 'mapbox_stamen-style' &&

// skip for now | TODO: figure out why needed this in https://github.com/plotly/plotly.js/pull/6610
a !== 'mapbox_custom-style'
);
});

if(mathjax3) {
allMockList = [
Expand Down
2 changes: 1 addition & 1 deletion test/image/export_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ var DEFAULT_LIST = [
'image_astronaut_source',
'gl2d_no-clustering2',
'gl3d_surface-heatmap-treemap_transparent-colorscale',
'mapbox_stamen-style',
'mapbox_density-multiple_legend',
'smith_modes',
'zsmooth_methods',
'fonts',
Expand Down
1 change: 1 addition & 0 deletions test/image/make_baseline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@
blacklist = [
'mapbox_density0-legend',
'mapbox_osm-style',
'mapbox_stamen-style', # used to pass before 2023 Jun 20
'mapbox_custom-style' # Figure out why needed this in https://github.com/plotly/plotly.js/pull/6610
]
allNames = [a for a in allNames if a not in blacklist]
Expand Down
2 changes: 1 addition & 1 deletion test/image/make_exports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
'image_astronaut_source',
'gl2d_no-clustering2',
'gl3d_surface-heatmap-treemap_transparent-colorscale',
'mapbox_stamen-style',
'mapbox_density-multiple_legend',
'smith_modes',
'zsmooth_methods',
'fonts',
Expand Down
2 changes: 1 addition & 1 deletion test/jasmine/tests/mapbox_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,7 +1513,7 @@ describe('mapbox plots', function() {
});
});

it('@gl should be displayed for style "stamen-watercolor"', function(done) {
it('@noCI @gl should be displayed for style "stamen-watercolor"', function(done) {
Plotly.newPlot(gd, [{type: 'scattermapbox'}], {mapbox: {style: 'stamen-watercolor'}})
.then(function() {
var s = d3SelectAll('.mapboxgl-ctrl-attrib');
Expand Down