Skip to content

fix bar and waterfall orientation descriptions #6607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2023
Merged

fix bar and waterfall orientation descriptions #6607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/traces/bar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module.exports = {
meta: {
description: [
'The data visualized by the span of the bars is set in `y`',
'if `orientation` is set th *v* (the default)',
'if `orientation` is set to *v* (the default)',
'and the labels are set in `x`.',
'By setting `orientation` to *h*, the roles are interchanged.'
].join(' ')
Expand Down
2 changes: 1 addition & 1 deletion src/traces/barpolar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ module.exports = {
hrName: 'bar_polar',
description: [
'The data visualized by the radial span of the bars is set in `r`'
// 'if `orientation` is set th *radial* (the default)',
// 'if `orientation` is set to *radial* (the default)',
// 'and the labels are set in `theta`.',
// 'By setting `orientation` to *angular*, the roles are interchanged.'
].join(' ')
Expand Down
2 changes: 1 addition & 1 deletion src/traces/waterfall/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module.exports = {
'Draws waterfall trace which is useful graph to displays the',
'contribution of various elements (either positive or negative)',
'in a bar chart. The data visualized by the span of the bars is',
'set in `y` if `orientation` is set th *v* (the default) and the',
'set in `y` if `orientation` is set to *v* (the default) and the',
'labels are set in `x`.',
'By setting `orientation` to *h*, the roles are interchanged.'
].join(' ')
Expand Down
4 changes: 2 additions & 2 deletions test/plot-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14302,7 +14302,7 @@
}
},
"meta": {
"description": "The data visualized by the span of the bars is set in `y` if `orientation` is set th *v* (the default) and the labels are set in `x`. By setting `orientation` to *h*, the roles are interchanged."
"description": "The data visualized by the span of the bars is set in `y` if `orientation` is set to *v* (the default) and the labels are set in `x`. By setting `orientation` to *h*, the roles are interchanged."
},
"type": "bar"
},
Expand Down Expand Up @@ -74486,7 +74486,7 @@
}
},
"meta": {
"description": "Draws waterfall trace which is useful graph to displays the contribution of various elements (either positive or negative) in a bar chart. The data visualized by the span of the bars is set in `y` if `orientation` is set th *v* (the default) and the labels are set in `x`. By setting `orientation` to *h*, the roles are interchanged."
"description": "Draws waterfall trace which is useful graph to displays the contribution of various elements (either positive or negative) in a bar chart. The data visualized by the span of the bars is set in `y` if `orientation` is set to *v* (the default) and the labels are set in `x`. By setting `orientation` to *h*, the roles are interchanged."
},
"type": "waterfall"
}
Expand Down