Skip to content

Implement draggable shapes #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 22, 2016
Merged

Implement draggable shapes #660

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
aba25e3
Shapes: make shapes draggable
n-riesco Jun 16, 2016
2802e0a
test: draggable shapes
n-riesco Jun 17, 2016
5a62051
test: try smaller shape drags
n-riesco Jun 17, 2016
d923637
Revert "test: try smaller shape drags"
n-riesco Jun 17, 2016
2340a96
test: replace MouseEvent with window.MouseEvent
n-riesco Jun 17, 2016
74173b4
Revert "test: replace MouseEvent with window.MouseEvent"
n-riesco Jun 17, 2016
0e522a9
test: compatibility workaround for Firefox 38
n-riesco Jun 17, 2016
d027674
Shapes: rename shapePath to getPathString
n-riesco Jun 21, 2016
9905594
Shapes: add function setupDragElement(node)
n-riesco Jun 21, 2016
e9f8ac4
Shapes: add startDrag, moveShape and endDrag
n-riesco Jun 21, 2016
abd8e93
Shapes: add line, rect and circle resize
n-riesco Jun 21, 2016
01903bd
test: Update shape drag test
n-riesco Jun 21, 2016
2167261
test: shapes are resizeable
n-riesco Jun 22, 2016
82b4102
DragElement: add options.setCursor
n-riesco Jun 22, 2016
ac15570
Shapes: update cursor before drag/resize
n-riesco Jun 22, 2016
5c1ff68
Shapes: shiftKey forces move drag mode
n-riesco Jun 22, 2016
e8b587c
test: draggable shapes referenced to timestamps
n-riesco Jun 22, 2016
5b965ab
Shapes: fix drag of shapes linked to timestamps
n-riesco Jun 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 27 additions & 24 deletions src/components/shapes/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,17 +361,35 @@ function setupDragElement(gd, shapePath, shapeOptions, index) {

var xa, ya, x2p, y2p, p2x, p2y;

var dragBBox, dragMode;

var dragOptions = {
element: shapePath.node(),
prepFn: startDrag,
doneFn: endDrag
};
setCursor: updateDragMode,
element: shapePath.node(),
prepFn: startDrag,
doneFn: endDrag
},
dragBBox = dragOptions.element.getBoundingClientRect(),
dragMode;

dragElement.init(dragOptions);

function startDrag(evt, startX, startY) {
function updateDragMode(evt) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. We should add a setCursor handler for annotations too.

That will deserve a PR of it own. Ticket here: #679

// choose 'move' or 'resize'
// based on initial position of cursor within the drag element
var w = dragBBox.right - dragBBox.left,
h = dragBBox.bottom - dragBBox.top,
x = evt.clientX - dragBBox.left,
y = evt.clientY - dragBBox.top,
cursor = (w > MINWIDTH && h > MINHEIGHT) ?
dragElement.getCursor(x / w, 1 - y / h) :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done here.

'move';

setCursor(shapePath, cursor);

// possible values 'move', 'sw', 'w', 'se', 'e', 'ne', 'n', 'nw' and 'w'
dragMode = cursor.split('-')[0];
}

function startDrag(evt) {
// setup conversion functions
xa = Axes.getFromId(gd, shapeOptions.xref);
ya = Axes.getFromId(gd, shapeOptions.yref);
Expand Down Expand Up @@ -418,23 +436,8 @@ function setupDragElement(gd, shapePath, shapeOptions, index) {

update = {};

// choose 'move' or 'resize'
// based on initial position of cursor within the drag element
dragBBox = dragOptions.element.getBoundingClientRect();

var w = dragBBox.right - dragBBox.left,
h = dragBBox.bottom - dragBBox.top,
x = startX - dragBBox.left,
y = startY - dragBBox.top,
cursor = (w > MINWIDTH && h > MINHEIGHT) ?
dragElement.getCursor(x / w, 1 - y / h) :
'move';

setCursor(shapePath, cursor);

// possible values 'move', 'sw', 'w', 'se', 'e', 'ne', 'n', 'nw' and 'w'
dragMode = cursor.split('-')[0];

// setup dragMode and the corresponding handler
updateDragMode(evt);
dragOptions.moveFn = (dragMode === 'move') ? moveShape : resizeShape;
}

Expand Down