Fix heatmap brick generation edge cases #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that it handle case where expected and actual array length differs.
| @@ -12,7 +12,10 @@ module.exports = { | |||
| return Math.abs(expected[i] - element) < precision; | |||
| }); | |||
|
|
|||
| var passed = tested.indexOf(false) < 0; | |||
| var passed = ( | |||
| expected.length === actual.length && | |||
There was a problem hiding this comment.
toBeCloseArray loops over the actual array which led to false positive assertions when the expected array is longer than the actual array.
The patch fixes this problem.
|
More clearly, test cases:
were failing before b913a5b . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #605
and also the case where
xoryis set to[]for heatmap and contour traces.This PR also adds a
toBeClose2DArraycustom jasmine matcher, which is convenient to assert 2D arrays like heatmap and contourz.