Alex's package lock changes after npm i #6418
Conversation
| "integrity": "sha512-nCeAiw37MIMA9w9IXso7bRaLl+c/ef3wnxsoSAlYrzS+Ot0zTG6nU8G/cIfGkqpkjX2wNaIW9RFG0TwIFnG6bA==", | ||
| "version": "3.99.1", | ||
| "resolved": "https://registry.npmjs.org/jasmine-core/-/jasmine-core-3.99.1.tgz", | ||
| "integrity": "sha512-Hu1dmuoGcZ7AfyynN3LsfruwMbxMALMka+YtZeGoLuDEySVmVAPaonkNoBRIw/ectu8b9tVQCJNgp4a4knp+tg==", |
There was a problem hiding this comment.
This part of diff is related to jasmine-core is fixed by #6423.
There was a problem hiding this comment.
ok - though after #6423 I still get node_modules/jasmine/node_modules/jasmine-core at v3.99.1, seems like more packages need pinning if you really want to avoid v3.99
There was a problem hiding this comment.
Thanks for testing. Please see my other comment.
| "resolved": "https://registry.npmjs.org/jasmine/-/jasmine-3.99.0.tgz", | ||
| "integrity": "sha512-YIThBuHzaIIcjxeuLmPD40SjxkEcc8i//sGMDKCgkRMVgIwRJf5qyExtlJpQeh7pkeoBSOe6lQEdg+/9uKg9mw==", | ||
| "dev": true, | ||
| "peer": true, |
There was a problem hiding this comment.
jasmine is required by karma-jasmine-spec-tags as a peer dependency [here].(https://github.com/mnasyrov/karma-jasmine-spec-tags/blob/61bd0cc0d62b1dd63b257feed30aeac8875659ae/package.json#L26)
npm@v8 somehow installs [email protected].
I am still investigating on this part so that we could be able to upgrade npm to v8 or higher.
There was a problem hiding this comment.
This part is now fixed by #6424.
Still not sure why I get this but @archmoj doesn't, but if it doesn't cause problems let's use it?