Skip to content

test for indicator trace: remove the invalid "ticker" option #6224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test for indicator trace: remove the invalid "ticker" option #6224

wants to merge 1 commit into from

Conversation

paulovieira
Copy link
Contributor

@paulovieira paulovieira commented Jun 13, 2022

The ticker option is not valid for indicator charts. In fact, I did a full search over the https://github.com/plotly/plotly.js repo and didn't find any mention for that option anywhere.

Related PR: plotly/graphing-library-docs#183

EDIT: seems like vmax is also invalid for indicator charts...

The `ticker` option is not valid for indicator charts. In fact, I did a full search over the https://github.com/plotly/plotly.js repo and didn't find any mention for that option anywhere.

Related PR: plotly/graphing-library-docs#183
@archmoj
Copy link
Contributor

archmoj commented Jun 13, 2022

Thanks for the PR.
It look like there are few other invalid attributes in that mock if you run:

npm run test-mock indicator_scatter

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants