-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Support version 3 of MathJax
and add config.typesetMath
#6073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note that this won't work if the page mathjax3 uses a chtml output plugin and AFAIU most people prefer chtml. A workaround requires creating a separate virtual document for MathJax to use in typesetting, see #4563 (comment) for a prototype implementation. EDIT: Also #4563 should be linked to this PR. |
Co-authored-by: Alex Johnson <[email protected]>
Another regression is that compared to the v2 API this doesn't preserve the MathJax settings. |
Thanks! Note that you don't actually need to mock v2 API to combine the outputs. I mocked the API to make it work with the current plotly implementation and combined with a second virtual document from another recipe. Instead you'll want to use just the recipe from mathjax/MathJax#2705 (comment). |
Good news. Let me fix that part then :) |
@akhmerov the PR is ready for your review :) |
Looks good! Only the question about @akhmerov thanks for the reviews! Re: |
@alexcjohnson this PR is pretty much ready for the final review. |
Co-authored-by: Alex Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Very nice work!
MathJax
and add config.typesetMath
…esetMath attribute to config (plotly/plotly.js#6073)
TODOs:
npm run mathjax3
npm run mathjax3chtml
when need to outputchtml
on the page as well assvg
output for plotly graphs | thanks to @akhmerov@plotly/plotly_js