Skip to content

Use maskTexture name for parcoords regl setup #5904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Aug 23, 2021

Renaming conflicting mask variable name to maskTexture.
This helped with using Chrome's pre-compiled regl functions in Firefox while addressing #897.

cc: @plotly/plotly_js

@archmoj archmoj merged commit ab75fbd into master Aug 23, 2021
@archmoj archmoj deleted the parcoords-regl-maskTexture-sampler branch August 23, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant