Skip to content

Adjust parcoords tests and revise karma config #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2021
Merged

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 5, 2021

Before this PR webgl-jasmine parcoords tests fail randomly as the browser disconnect (sometimes succeed once out of 8 runs).

https://app.circleci.com/pipelines/github/plotly/plotly.js/3731/workflows/98768ace-6fe1-47c7-9db4-0f586e85b9c1/jobs/111372
parcoords_test

This was clearly annoying (also hard to debug) for any development/maintenance work.
This PR addresses that by making each run more stable.

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone May 5, 2021
@archmoj archmoj merged commit 0cc1c82 into master May 5, 2021
@archmoj archmoj deleted the fixup-parcoords-karma branch May 5, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant